mon: OSDMonitor: return -EINVAL on not-a-uuid during 'osd create'

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>

diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc
index e72929b7d43c2c6d4b86ec6f42040310cd79fecd..2b1b48b605dd142e1a0a419d3050767a48377aba 100644 (file)
--- a/src/mon/OSDMonitor.cc
+++ b/src/mon/OSDMonitor.cc
@@ -2445,7 +2445,11 @@ bool OSDMonitor::prepare_command(MMonCommand *m)
 
       // optional uuid provided?
       uuid_d uuid;
-      if (m->cmd.size() > 2 && uuid.parse(m->cmd[2].c_str())) {
+      if (m->cmd.size() > 2) {
+        if (!uuid.parse(m->cmd[2].c_str())) {
+          err = -EINVAL;
+          goto out;
+        }
        dout(10) << " osd create got uuid " << uuid << dendl;
        i = osdmap.identify_osd(uuid);
        if (i >= 0) {