]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
config: fix recursive lock in parse_config_files()
authorSage Weil <sage@inktank.com>
Tue, 3 Jul 2012 15:15:08 +0000 (08:15 -0700)
committerSage Weil <sage@inktank.com>
Fri, 6 Jul 2012 23:45:05 +0000 (16:45 -0700)
The _impl() helper is only called from parse_config_files(); don't retake
the lock.

Signed-off-by: Sage Weil <sage@inktank.com>
src/common/config.cc

index 0b53f3969add2f27c0d8d077de2529fd5905b216..4dce990cdb930a20ae0919eed879315ac3fbe8f8 100644 (file)
@@ -198,7 +198,8 @@ int md_config_t::parse_config_files(const char *conf_files,
 int md_config_t::parse_config_files_impl(const std::list<std::string> &conf_files,
                                         std::deque<std::string> *parse_errors)
 {
-  Mutex::Locker l(lock);
+  assert(lock.is_locked());
+
   // open new conf
   list<string>::const_iterator c;
   for (c = conf_files.begin(); c != conf_files.end(); ++c) {