mon: remove the silly write_bl_ss write_bl_ss_impl distinction

It was introduced at the same time as all these unchecked return codes,
but I can't tell why.

Signed-off-by: Greg Farnum <greg@inktank.com>

diff --git a/src/mon/MonitorStore.cc b/src/mon/MonitorStore.cc
index 0b7bc3a93876cb1c919ed0ce642fc2854e90f90d..a74b750787c0b56db0b8b447d0b5cd2c9ddd6261 100644 (file)
--- a/src/mon/MonitorStore.cc
+++ b/src/mon/MonitorStore.cc
@@ -339,7 +339,7 @@ int MonitorStore::get_bl_ss(bufferlist& bl, const char *a, const char *b)
   return len;
 }
 
-void MonitorStore::write_bl_ss_impl(bufferlist& bl, const char *a, const char *b, bool append)
+void MonitorStore::write_bl_ss(bufferlist& bl, const char *a, const char *b, bool append)
 {
   int err = 0;
   char fn[1024];
@@ -395,11 +395,6 @@ void MonitorStore::write_bl_ss_impl(bufferlist& bl, const char *a, const char *b
   }
 }
 
-void MonitorStore::write_bl_ss(bufferlist& bl, const char *a, const char *b, bool append)
-{
-  write_bl_ss_impl(bl, a, b, append);
-}
-
 void MonitorStore::put_bl_sn_map(const char *a,
                                map<version_t,bufferlist>::iterator start,
                                map<version_t,bufferlist>::iterator end,

diff --git a/src/mon/MonitorStore.h b/src/mon/MonitorStore.h
index a77bba303d166f54c0e6f67ce22ab9bd864f1f20..2e5cf0af6e6a2c7ad5d529bf898a7fbde67d2bf6 100644 (file)
--- a/src/mon/MonitorStore.h
+++ b/src/mon/MonitorStore.h
@@ -26,8 +26,6 @@ class MonitorStore {
   string dir;
   int lock_fd;
 
-  void write_bl_ss_impl(bufferlist& bl, const char *a, const char *b,
-                      bool append);
   void write_bl_ss(bufferlist& bl, const char *a, const char *b,
                  bool append);
 public: