]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
qa: make execution abortion optional for command ran through run_shell()
authorRishabh Dave <ridave@redhat.com>
Wed, 20 Feb 2019 16:33:00 +0000 (22:03 +0530)
committerRamana Raja <rraja@redhat.com>
Mon, 16 Mar 2020 09:48:58 +0000 (15:18 +0530)
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 5df2b82c4f9ce71cd82889531333be184c84707c)

qa/tasks/cephfs/mount.py
qa/tasks/vstart_runner.py

index 8d07323d859efc7cff55fa805df171799105941e..c3d58c86180cecc695dc91976f618d1a18735ec6 100644 (file)
@@ -155,10 +155,11 @@ class CephFSMount(object):
         p.wait()
         return p.stdout.getvalue().strip()
 
-    def run_shell(self, args, wait=True):
+    def run_shell(self, args, wait=True, check_status=True):
         args = ["cd", self.mountpoint, run.Raw('&&'), "sudo"] + args
         return self.client_remote.run(args=args, stdout=StringIO(),
-                                      stderr=StringIO(), wait=wait)
+                                      stderr=StringIO(), wait=wait,
+                                      check_status=check_status)
 
     def open_no_data(self, basename):
         """
index 74b26d23df466ea6cd37aac62672004f87f753fc..0d2247ccbdb719078ac5fbc9243b9205e8f41d29 100644 (file)
@@ -418,13 +418,12 @@ class LocalFuseMount(FuseMount):
         # to avoid assumptions about daemons' pwd
         return os.path.abspath("./client.{0}.keyring".format(self.client_id))
 
-    def run_shell(self, args, wait=True):
+    def run_shell(self, args, wait=True, check_status=True):
         # FIXME maybe should add a pwd arg to teuthology.orchestra so that
         # the "cd foo && bar" shenanigans isn't needed to begin with and
         # then we wouldn't have to special case this
-        return self.client_remote.run(
-            args, wait=wait, cwd=self.mountpoint
-        )
+        return self.client_remote.run(args, wait=wait, cwd=self.mountpoint,
+                                      check_status=check_status)
 
     def setupfs(self, name=None):
         if name is None and self.fs is not None: