]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
osd: do not send dup failure reports
authorSage Weil <sage@redhat.com>
Fri, 18 Sep 2015 01:45:16 +0000 (21:45 -0400)
committerSage Weil <sage@redhat.com>
Mon, 23 Nov 2015 13:36:14 +0000 (08:36 -0500)
If a failure report is already pending, we do not need to resend
it.

Signed-off-by: Sage Weil <sage@redhat.com>
src/osd/OSD.cc

index b528914e39d72b4e071e521a2f6422014312356d..5b49ebd4604cb0a212808d1187443b129e0c5ee7 100644 (file)
@@ -4743,11 +4743,13 @@ void OSD::send_failures()
   utime_t now = ceph_clock_now(cct);
   while (!failure_queue.empty()) {
     int osd = failure_queue.begin()->first;
-    int failed_for = (int)(double)(now - failure_queue.begin()->second);
     entity_inst_t i = osdmap->get_inst(osd);
-    monc->send_mon_message(new MOSDFailure(monc->get_fsid(), i, failed_for,
-                                          osdmap->get_epoch()));
-    failure_pending[osd] = make_pair(failure_queue.begin()->second, i);
+    if (!failure_pending.count(osd)) {
+      int failed_for = (int)(double)(now - failure_queue.begin()->second);
+      monc->send_mon_message(new MOSDFailure(monc->get_fsid(), i, failed_for,
+                                            osdmap->get_epoch()));
+      failure_pending[osd] = make_pair(failure_queue.begin()->second, i);
+    }
     failure_queue.erase(osd);
   }
 }