]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
common: Fix some configuration descriptions
authorDavid Zafman <dzafman@redhat.com>
Tue, 22 Jan 2019 02:20:20 +0000 (18:20 -0800)
committerDavid Zafman <dzafman@redhat.com>
Mon, 18 Feb 2019 18:56:26 +0000 (10:56 -0800)
osd_scrub_backoff_ratio
osd_deep_scrub_randomize_ratio

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit aa4fc197858bfd94924c09aada1c408c8ef01273)

src/common/options.cc

index 532411ee0f8fcd2b4dcee78fa9aed31c3d1b9f5f..8bf2f24830cbf89303c6cc6f4fff1f50d7292b3f 100644 (file)
@@ -3041,7 +3041,8 @@ std::vector<Option> get_global_options() {
 
     Option("osd_scrub_backoff_ratio", Option::TYPE_FLOAT, Option::LEVEL_DEV)
     .set_default(.66)
-    .set_description("Backoff ratio after a failed scrub scheduling attempt"),
+    .set_long_description("This is the precentage of ticks that do NOT schedule scrubs, 66% means that 1 out of 3 ticks will schedule scrubs")
+    .set_description("Backoff ratio for scheduling scrubs"),
 
     Option("osd_scrub_chunk_min", Option::TYPE_INT, Option::LEVEL_ADVANCED)
     .set_default(5)
@@ -3076,9 +3077,8 @@ std::vector<Option> get_global_options() {
 
     Option("osd_deep_scrub_randomize_ratio", Option::TYPE_FLOAT, Option::LEVEL_ADVANCED)
     .set_default(0.15)
-    .set_description("Ratio of deep scrub interval to randomly vary")
-    .set_long_description("This prevents a deep scrub 'stampede' by randomly varying the scrub intervals so that they are soon uniformly distributed over the week")
-    .add_see_also("osd_deep_scrub_interval"),
+    .set_description("Scrubs will randomly become deep scrubs at this rate (0.15 -> 15% of scrubs are deep)")
+    .set_long_description("This prevents a deep scrub 'stampede' by spreading deep scrubs so they are uniformly distributed over the week"),
 
     Option("osd_deep_scrub_stride", Option::TYPE_SIZE, Option::LEVEL_ADVANCED)
     .set_default(512_K)