]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
qa/rgw: fix perl tests missing Amazon::S3 module 64227/head
authorMark Kogan <mkogan@redhat.com>
Wed, 25 Jun 2025 12:21:49 +0000 (12:21 +0000)
committerAdam C. Emerson <aemerson@redhat.com>
Fri, 27 Jun 2025 15:33:20 +0000 (11:33 -0400)
and a second case where perl tests can fail without error output

1. fix errors like: `Can't locate Amazon/S3.pm in @INC (you may need to
   install the Amazon::S3 module)`
by priming the perl tests with installing the Amazon::S3 module from cpan

ex:
```
2025-06-23T19:18:40.162 INFO:tasks.workunit.client.0.smithi090.stderr:Can't locate Amazon/S3.pm in @INC (you may need to install the Amazon::S3 module) (@INC contains: /usr/local/lib64/perl5/5.32 ...
```

2. log an error when RGW process is not detected

Fixes: https://tracker.ceph.com/issues/71577
Signed-off-by: Mark Kogan <mkogan@redhat.com>
(cherry picked from commit 7faa23f160c9f4b40d25fe27f2345dbf999b0c84)

Conflicts:
qa/suites/rgw/multifs/0-install.yaml
 - Doesn't exist in this branch, or support for it, so duplicated in
   individual tests.
qa/suites/rgw/multifs/tasks/rgw_bucket_quota.yaml
qa/suites/rgw/multifs/tasks/rgw_multipart_upload.yaml
qa/suites/rgw/multifs/tasks/rgw_user_quota.yaml
 - Has overrides no longer needed in main

Fixes: https://tracker.ceph.com/issues/71873
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
qa/suites/rgw/multifs/tasks/rgw_bucket_quota.yaml
qa/suites/rgw/multifs/tasks/rgw_multipart_upload.yaml
qa/suites/rgw/multifs/tasks/rgw_user_quota.yaml
qa/suites/rgw/thrash/install.yaml
qa/suites/rgw/thrash/workload/rgw_bucket_quota.yaml
qa/suites/rgw/thrash/workload/rgw_multipart_upload.yaml
qa/suites/rgw/thrash/workload/rgw_user_quota.yaml
qa/workunits/rgw/s3_bucket_quota-run.sh [new file with mode: 0755]
qa/workunits/rgw/s3_multipart_upload-run.sh [new file with mode: 0755]
qa/workunits/rgw/s3_user_quota-run.sh [new file with mode: 0755]
qa/workunits/rgw/s3_utilities.pm

index e07c8b5ccfe85a95bec9ed42c46a0c0932c08d07..a791d9b76a8708a81e3540a6921615765699534a 100644 (file)
@@ -1,11 +1,14 @@
 tasks:
 - install:
+    extra_system_packages:
+      deb: ['cpanminus', 'libxml-simple-perl']
+      rpm: ['cpanminus', 'perl-XML-Simple', 'perl-LWP-Protocol-https', 'perl-ExtUtils-Config', 'perl-ExtUtils-Helpers', 'perl-ExtUtils-InstallPaths', 'perl-Module-Build-Tiny']
 - ceph:
 - rgw: [client.0]
 - workunit:
     clients:
       client.0:
-        - rgw/s3_bucket_quota.pl
+        - rgw/s3_bucket_quota-run.sh
 overrides:
   ceph:
     conf:
index bac4f4016264e561659cdd94fa0f87d64e0a0549..e8499dcf40f1b995d1c81d1dabc641ca43fd3915 100644 (file)
@@ -1,11 +1,14 @@
 tasks:
 - install:
+    extra_system_packages:
+      deb: ['cpanminus', 'libxml-simple-perl']
+      rpm: ['cpanminus', 'perl-XML-Simple', 'perl-LWP-Protocol-https', 'perl-ExtUtils-Config', 'perl-ExtUtils-Helpers', 'perl-ExtUtils-InstallPaths', 'perl-Module-Build-Tiny']
 - ceph:
 - rgw: [client.0]
 - workunit:
     clients:
       client.0:
-        - rgw/s3_multipart_upload.pl
+        - rgw/s3_multipart_upload-run.sh
 overrides:
   ceph:
     conf:
index 92c63d2e85019d1abd016d2cfc662bb1cf78e35f..1e204b2df92e0dac3e3e0f9fd5844256405cc171 100644 (file)
@@ -1,11 +1,14 @@
 tasks:
 - install:
+    extra_system_packages:
+      deb: ['cpanminus', 'libxml-simple-perl']
+      rpm: ['cpanminus', 'perl-XML-Simple', 'perl-LWP-Protocol-https', 'perl-ExtUtils-Config', 'perl-ExtUtils-Helpers', 'perl-ExtUtils-InstallPaths', 'perl-Module-Build-Tiny']
 - ceph:
 - rgw: [client.0]
 - workunit:
     clients:
       client.0:
-        - rgw/s3_user_quota.pl
+        - rgw/s3_user_quota-run.sh
 overrides:
   ceph:
     conf:
index 84a1d70cfba86cb16dce6e71e2904b6fb55ca9ca..637aaf9cb1df0d34ac239457dbd7a73045006aa2 100644 (file)
@@ -1,5 +1,8 @@
 tasks:
 - install:
+    extra_system_packages:
+      deb: ['cpanminus', 'libxml-simple-perl']
+      rpm: ['cpanminus', 'perl-XML-Simple', 'perl-LWP-Protocol-https', 'perl-ExtUtils-Config', 'perl-ExtUtils-Helpers', 'perl-ExtUtils-InstallPaths', 'perl-Module-Build-Tiny']
 - ceph:
 - rgw: [client.0]
 
index bc441ff326591d2a48a6d416f3ea6e08a0358c47..f167fc8af6e6980681e24f34827e0798c580aed3 100644 (file)
@@ -2,7 +2,7 @@ tasks:
 - workunit:
     clients:
       client.0:
-        - rgw/s3_bucket_quota.pl
+        - rgw/s3_bucket_quota-run.sh
 overrides:
   ceph:
     conf:
index 1b98f26255828a7cedf98e88318f9992a6298d09..7fdef0898a06ee9840308c102654442141b255d6 100644 (file)
@@ -2,7 +2,7 @@ tasks:
 - workunit:
     clients:
       client.0:
-        - rgw/s3_multipart_upload.pl
+        - rgw/s3_multipart_upload-run.sh
 overrides:
   ceph:
     conf:
index 75ba3d4749b4ae0e65f9d5b56370f4b9adb3e4bc..59884cd08231561cec2d9589240bc03a293da696 100644 (file)
@@ -2,7 +2,7 @@ tasks:
 - workunit:
     clients:
       client.0:
-        - rgw/s3_user_quota.pl
+        - rgw/s3_user_quota-run.sh
 overrides:
   ceph:
     conf:
diff --git a/qa/workunits/rgw/s3_bucket_quota-run.sh b/qa/workunits/rgw/s3_bucket_quota-run.sh
new file mode 100755 (executable)
index 0000000..b57b802
--- /dev/null
@@ -0,0 +1,4 @@
+#!/bin/bash
+set -ex
+cpanm --sudo Amazon::S3
+exec perl $(dirname $0)/s3_bucket_quota.pl
diff --git a/qa/workunits/rgw/s3_multipart_upload-run.sh b/qa/workunits/rgw/s3_multipart_upload-run.sh
new file mode 100755 (executable)
index 0000000..db89c4c
--- /dev/null
@@ -0,0 +1,4 @@
+#!/bin/bash
+set -ex
+cpanm --sudo Amazon::S3
+exec perl $(dirname $0)/s3_multipart_upload.pl
diff --git a/qa/workunits/rgw/s3_user_quota-run.sh b/qa/workunits/rgw/s3_user_quota-run.sh
new file mode 100755 (executable)
index 0000000..ce3abdb
--- /dev/null
@@ -0,0 +1,4 @@
+#!/bin/bash
+set -ex
+cpanm --sudo Amazon::S3
+exec perl $(dirname $0)/s3_user_quota.pl
index 3c3fae900e835c24677c64da38ec2be9019f23a2..2622c1e3b9a9c24e496a69f2ecbef386948f2dbe 100644 (file)
@@ -32,6 +32,7 @@ sub get_status {
     if ($status =~ /\d+/ ){
         return 0;
     }
+    warn "ERROR: $service is not running\n";
     return 1;
 }