]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
test/crimson/seastore/test_seastore.cc: should not return a value 58955/head
authorMatan Breizman <mbreizma@redhat.com>
Tue, 9 Jul 2024 16:33:45 +0000 (16:33 +0000)
committerMatan Breizman <mbreizma@redhat.com>
Wed, 31 Jul 2024 08:45:16 +0000 (11:45 +0300)
clang++-14:

```
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/crimson/seastore/test_seastore.cc:86:5: error: void function 'do_transaction' should not return a value [-Wreturn-type]
    return sharded_seastore->do_transaction(
    ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/crimson/seastore/test_seastore.cc:94:5: error: void function 'set_meta' should not return a value [-Wreturn-type]
    return seastore->write_meta(key, value).get();
    ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit 28a7ee81280073eb387ea3b7c8de5204be45f453)

src/test/crimson/seastore/test_seastore.cc

index 7e2ac3ff923f58ff592f8cf95bd15b72516118d5..e4a522f02746a61b9b3a046d7827958c358b5447 100644 (file)
@@ -83,7 +83,7 @@ struct seastore_test_t :
   }
 
   void do_transaction(CTransaction &&t) {
-    return sharded_seastore->do_transaction(
+    return (void)sharded_seastore->do_transaction(
       coll,
       std::move(t)).get();
   }
@@ -91,7 +91,7 @@ struct seastore_test_t :
   void set_meta(
     const std::string& key,
     const std::string& value) {
-    return seastore->write_meta(key, value).get();
+    return (void)seastore->write_meta(key, value).get();
   }
 
   std::tuple<int, std::string> get_meta(