lirgw: call RGWHanlder_Lib::init_from_header

Call this from the general RGWLibRequest init() method, after
descendant header_init() has run.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

diff --git a/src/rgw/librgw.cc b/src/rgw/librgw.cc
index 8e7b4e57836bc23b13aa0a20641bba5b069fbc23..4c861c7a1922da629247501358467ae3b13dec4c 100644 (file)
--- a/src/rgw/librgw.cc
+++ b/src/rgw/librgw.cc
@@ -223,8 +223,6 @@ int RGWLibProcess::process_request(RGWLibRequest* req, RGWLibIO* io)
     goto done;
   }
 
-  /* XXXX almost correct, I think */
-  #if 0
   req->log(s, "verifying op permissions");
   ret = op->verify_permission();
   if (ret < 0) {
@@ -235,8 +233,6 @@ int RGWLibProcess::process_request(RGWLibRequest* req, RGWLibIO* io)
       goto done;
     }
   }
-  #endif
-  req->log(s, "here 3");
 
   req->log(s, "verifying op params");
   ret = op->verify_params();
@@ -273,9 +269,8 @@ done:
 
 int RGWLibFrontend::init()
 {
-  /* XXX */
   pprocess = new RGWLibProcess(g_ceph_context, &env,
-                              g_conf->rgw_thread_pool_size, conf);
+                             g_conf->rgw_thread_pool_size, conf);
   return 0;
 }
 

diff --git a/src/rgw/rgw_lib.h b/src/rgw/rgw_lib.h
index a2e5b0cb19a8b633ca4ea88b748e29c00f5e189c..132288647805f61324ac7dcbe303c09466c053f4 100644 (file)
--- a/src/rgw/rgw_lib.h
+++ b/src/rgw/rgw_lib.h
@@ -142,7 +142,11 @@ public:
     log_format(_s, "initializing for trans_id = %s",
              get_state()->trans_id.c_str());
 
-    return header_init();
+    int ret = header_init();
+    if (ret == 0) {
+      ret = init_from_header(_s);
+    }
+    return ret;
   }
 
   virtual bool only_bucket() = 0;

diff --git a/src/rgw/rgw_rest_lib.cc b/src/rgw/rgw_rest_lib.cc
index 718ae9da157fa23e4822c8993d147b9d50c2c539..55078bcce9b35b6b4efc39c9bd1312ea1850ac7e 100644 (file)
--- a/src/rgw/rgw_rest_lib.cc
+++ b/src/rgw/rgw_rest_lib.cc
@@ -7,9 +7,7 @@
 #include "rgw_rest_lib.h"
 #include "rgw_file.h"
 
-/* XXX going away ! */
 
-#warning kill me
 /* static */
 int RGWHandler_Lib::init_from_header(struct req_state *s)
 {