]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
test_librbd: rollback when mapped to a snapshot should fail
authorJosh Durgin <josh.durgin@dreamhost.com>
Thu, 26 Apr 2012 18:33:56 +0000 (11:33 -0700)
committerJosh Durgin <josh.durgin@dreamhost.com>
Thu, 26 Apr 2012 19:41:13 +0000 (12:41 -0700)
Rollback is effectively a write, and returns -EROFS when mapped to a
snapshot since 3ef3ab8a15b4a80a340ac6039f395738223df759.

Signed-off-by: Josh Durgin <josh.durgin@dreamhost.com>
Reviewed-by: Samuel Just <samuel.just@dreamhost.com>
src/test/test_librbd.cc

index d5f3ddc813984af2b91dce0750b6cce892a2bfeb..89c5797de5edb99ccf3484e79e62feb5cd7bf35e 100644 (file)
@@ -879,11 +879,13 @@ TEST(LibRBD, TestIOToSnapshot)
   read_test_data(image, test_data, 0, TEST_IO_TO_SNAP_SIZE);
 
   r = rbd_snap_rollback(image, "orig");
-  printf("rbd_snap_rollback returned %d\n", r);
-  ASSERT_GE(r, 0);
+  ASSERT_EQ(r, -EROFS);
 
   r = rbd_snap_set(image, NULL);
   ASSERT_EQ(r, 0);
+  r = rbd_snap_rollback(image, "orig");
+  ASSERT_EQ(r, 0);
+
   write_test_data(image, test_data, 0, TEST_IO_TO_SNAP_SIZE);
 
   rbd_flush(image);