]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rbd-mirror: decode_client_meta should return false on error
authorMykola Golub <mgolub@mirantis.com>
Tue, 26 Jul 2016 13:10:30 +0000 (16:10 +0300)
committerMykola Golub <mgolub@mirantis.com>
Mon, 5 Sep 2016 05:51:54 +0000 (08:51 +0300)
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
src/tools/rbd_mirror/image_replayer/BootstrapRequest.cc

index 4bed7562c5f7fc1b3a942b43b670c12c8103a287..13004ebbe0d59bbc2422d89ef4bb1b5c3279d466 100644 (file)
@@ -728,14 +728,14 @@ bool BootstrapRequest<I>::decode_client_meta() {
     ::decode(client_data, it);
   } catch (const buffer::error &err) {
     derr << ": failed to decode client meta data: " << err.what() << dendl;
-    return true;
+    return false;
   }
 
   librbd::journal::MirrorPeerClientMeta *client_meta =
     boost::get<librbd::journal::MirrorPeerClientMeta>(&client_data.client_meta);
   if (client_meta == nullptr) {
     derr << ": unknown peer registration" << dendl;
-    return true;
+    return false;
   } else if (!client_meta->image_id.empty()) {
     // have an image id -- use that to open the image
     m_local_image_id = client_meta->image_id;