]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
os/store_test: Change test limits
authorAdam Kupczyk <akupczyk@ibm.com>
Mon, 20 Feb 2023 08:52:48 +0000 (08:52 +0000)
committerAdam Kupczyk <akupczyk@ibm.com>
Wed, 9 Aug 2023 07:51:58 +0000 (07:51 +0000)
Test ReproNoBlobMultiTest required very narrow value of l_bluestore_gc_merged.
After ExtentMap::dup changes it can no longer reach it.
Generally that perf counter is useless; as we have now less allocated space
912798515 vs 9160228864 before.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
src/test/objectstore/store_test.cc

index c38924690833ab20f0bfa2b8687dba508a0a5d33..84238a530a973f7571fec94064b982e2131caafa 100644 (file)
@@ -10418,8 +10418,22 @@ TEST_P(StoreTestSpecificAUSize, ReproNoBlobMultiTest) {
   }
   {
     cerr << "Finalizing" << std::endl;
+    // before ExtentMap::dup blob merge refector:
+    // allocated = 9160228864
+    // l_bluestore_gc_merged = 1094856704
+    // after ExtentMap::dup change:
+    // allocated = 9127985152
+    // l_bluestore_gc_merged = 1055684096
+    // This generally shows that we should not take seriously this test.
+    // We allocated ~9GB to create sequence of 512 objects that
+    // Ai < A(i+1) < A(i+2) < ... < A(512)
+    // and size of A(512) is less then 128M.
+    struct store_statfs_t statfs;
+    int r = store->statfs(&statfs);
+    ASSERT_EQ(r, 0);
     const PerfCounters* logger = store->get_perf_counters();
-    ASSERT_GE(logger->get(l_bluestore_gc_merged), 1024*1024*1024);
+    ASSERT_GE(logger->get(l_bluestore_gc_merged), 900*1024*1024);
+    ASSERT_LE(statfs.allocated, 9LL*1024*1024*1024);
   }
 }