]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw/logging: log only object ACls in journal mode 63750/head
authorYuval Lifshitz <ylifshit@ibm.com>
Thu, 5 Jun 2025 07:48:07 +0000 (07:48 +0000)
committerYuval Lifshitz <ylifshit@ibm.com>
Thu, 5 Jun 2025 07:48:07 +0000 (07:48 +0000)
Fixes: https://tracker.ceph.com/issues/71563
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
src/rgw/rgw_op.cc

index 92fade2bfbb66bfdf1e36b8af7de2f98f634f222..349f23615f35e72d7f12aac315381dcdd31c9ac5 100644 (file)
@@ -6370,17 +6370,20 @@ void RGWPutACLs::execute(optional_yield y)
     return;
   }
 
-  const auto etag = s->object->get_attrs()[RGW_ATTR_ETAG].to_str();
-  op_ret = rgw::bucketlogging::log_record(driver,
-      rgw::bucketlogging::LoggingType::Journal,
-      s->object.get(),
-      s,
-      canonical_name(),
-      etag,
-      s->object->get_size(),
-      this, y, false, false);
-  if (op_ret < 0) {
-    return;
+  if (!rgw::sal::Object::empty(s->object)) {
+    // in journal mode we log only object ACLs
+    const auto etag = s->object->get_attrs()[RGW_ATTR_ETAG].to_str();
+    op_ret = rgw::bucketlogging::log_record(driver,
+        rgw::bucketlogging::LoggingType::Journal,
+        s->object.get(),
+        s,
+        canonical_name(),
+        etag,
+        s->object->get_size(),
+        this, y, false, false);
+    if (op_ret < 0) {
+      return;
+    }
   }
 
   bufferlist bl;