common: take string_view for strict_tobool

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
(cherry picked from commit 89d3fb05d2732dcf1b8ba9e05130e6a12923c6e0)

diff --git a/src/common/strtol.cc b/src/common/strtol.cc
index c97942adec53dbe2368ebc92864ae9a3d2b6c0e9..0e197535b7ac7162cf8cb47270d005c655cd18ad 100644 (file)
--- a/src/common/strtol.cc
+++ b/src/common/strtol.cc
@@ -22,13 +22,16 @@
 #include <strings.h>
 #include <string_view>
 
+#include <boost/algorithm/string/predicate.hpp>
+
 using std::ostringstream;
+using namespace std::literals::string_view_literals;
 
-bool strict_strtob(const char* str, std::string *err)
+bool strict_strtob(std::string_view str, std::string *err)
 {
-  if (strcasecmp(str, "false") == 0) {
+  if (boost::iequals(str, "false"sv)) {
     return false;
-  } else if (strcasecmp(str, "true") == 0) {
+  } else if (boost::iequals(str, "true"sv)) {
     return true;
   } else {
     int b = strict_strtol(str, 10, err);

diff --git a/src/common/strtol.h b/src/common/strtol.h
index 2183137b1edf9c6bd1e27cf8692d18e518402d02..681ac1a290c84c383efd37c8db17b4ec19114408 100644 (file)
--- a/src/common/strtol.h
+++ b/src/common/strtol.h
@@ -69,7 +69,7 @@ auto consume(std::string_view& s, int base = 10)
 }
 } // namespace ceph
 
-bool strict_strtob(const char* str, std::string *err);
+bool strict_strtob(std::string_view str, std::string *err);
 
 long long strict_strtoll(std::string_view str, int base, std::string *err);