mds/Server.cc: fix dereference after null check

CID 716927 (#1 of 1): Dereference after null check (FORWARD_NULL)
  var_deref_model: Passing null pointer "diri->snaprealm" to function
  "SnapRealm::resolve_snapname(std::string const &

Make sure not to dereference diri->snaprealm.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index 5b23b7ff83728920e1478b37f7d9374aacde2f04..abeea2c12d5fbd339553917eb16c02cd5660621a 100644 (file)
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -7445,8 +7445,7 @@ void Server::handle_client_rmsnap(MDRequest *mdr)
     reply_request(mdr, -EINVAL);   // can't prune a parent snap, currently.
     return;
   }
-  if (diri->snaprealm &&
-      !diri->snaprealm->exists(snapname)) {
+  if (!diri->snaprealm || !diri->snaprealm->exists(snapname)) {
     reply_request(mdr, -ENOENT);
     return;
   }