]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
python-common: don't accept pool/ns for NFSServiceSpec
authorSage Weil <sage@newdream.net>
Fri, 2 Jul 2021 18:43:56 +0000 (14:43 -0400)
committerSage Weil <sage@newdream.net>
Wed, 14 Jul 2021 20:20:11 +0000 (16:20 -0400)
All users are now gone.

Signed-off-by: Sage Weil <sage@newdream.net>
src/python-common/ceph/deployment/service_spec.py

index 57e88cb8f73a0e90125a0d550fa55aaa8d280dc1..e8c47b4e47b7fcc6fa23fd63c9ed7587ac2e4fc0 100644 (file)
@@ -663,8 +663,6 @@ yaml.add_representer(ServiceSpec, ServiceSpec.yaml_representer)
 
 
 class NFSServiceSpec(ServiceSpec):
-    DEFAULT_POOL = '.nfs'
-
     def __init__(self,
                  service_type: str = 'nfs',
                  service_id: Optional[str] = None,
@@ -673,8 +671,6 @@ class NFSServiceSpec(ServiceSpec):
                  preview_only: bool = False,
                  config: Optional[Dict[str, str]] = None,
                  networks: Optional[List[str]] = None,
-                 pool: Optional[str] = None,
-                 namespace: Optional[str] = None,
                  port: Optional[int] = None,
                  ):
         assert service_type == 'nfs'
@@ -685,10 +681,6 @@ class NFSServiceSpec(ServiceSpec):
 
         self.port = port
 
-        # these fields are obsolete; remove from __init__ and this assert eventually.
-        assert pool is None or pool == self.DEFAULT_POOL
-        assert namespace is None or namespace == self.service_id
-
     def get_port_start(self) -> List[int]:
         if self.port:
             return [self.port]