common/buffer: correct list_iterator::operator!= behavior

It was actually behaving as if it were operator==.  This results
in loops running off the end of empty bufferlists.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

diff --git a/src/common/buffer.cc b/src/common/buffer.cc
index ae1ffbe4b3f3d97675a561120da6fd4fcc854c7f..eb43810a3250333105e0e72dc34bd23f39087f0e 100644 (file)
--- a/src/common/buffer.cc
+++ b/src/common/buffer.cc
@@ -1085,7 +1085,7 @@ static simple_spinlock_t buffer_debug_lock = SIMPLE_SPINLOCK_INITIALIZER;
   template<bool is_const>
   bool buffer::list::iterator_impl<is_const>::operator!=(const buffer::list::iterator_impl<is_const>& rhs) const
   {
-    return bl == rhs.bl && off == rhs.off;
+    return bl != rhs.bl || off != rhs.off;
   }
 
   template<bool is_const>