]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw: fix resource leak
authorYehuda Sadeh <yehuda@inktank.com>
Thu, 27 Sep 2012 19:44:33 +0000 (12:44 -0700)
committerYehuda Sadeh <yehuda@inktank.com>
Mon, 8 Oct 2012 22:07:48 +0000 (15:07 -0700)
coverity bug 728055

Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
src/rgw/rgw_rest_s3.cc

index 512c8cf6b54c4ba24a05a8a6bdf5f698e077d3ba..f211997fc0e80ed854fd49aca41653b6333ed0f6 100644 (file)
@@ -622,17 +622,17 @@ void RGWDeleteMultiObj_ObjStore_S3::send_partial_response(pair<string,int>& resu
       s->formatter->dump_string("Key", result.first);
       s->formatter->close_section();
     } else if (result.first < 0) {
-      struct rgw_html_errors *r = new rgw_html_errors;
+      struct rgw_html_errors r;
       int err_no;
 
       s->formatter->open_object_section("Error");
 
       err_no = -(result.second);
-      rgw_get_errno_s3(r, err_no);
+      rgw_get_errno_s3(&r, err_no);
 
       s->formatter->dump_string("Key", result.first);
-      s->formatter->dump_int("Code", r->http_ret);
-      s->formatter->dump_string("Message", r->s3_code);
+      s->formatter->dump_int("Code", r.http_ret);
+      s->formatter->dump_string("Message", r.s3_code);
       s->formatter->close_section();
     }