]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rpm: unconditionally package rbd-replay-prep(8) 4865/head
authorKen Dreyer <kdreyer@redhat.com>
Wed, 26 Nov 2014 23:49:53 +0000 (16:49 -0700)
committerLoic Dachary <ldachary@redhat.com>
Fri, 5 Jun 2015 06:22:18 +0000 (08:22 +0200)
The build system will conditionally build and install the
rbd-replay-prep utility based on the presence of lttng.

Commit 230c5b8e7f58e2e8be32c3f31c6abcc5bdabc5ca adjusted the RPM
packaging so that we only package and ship the rbd-replay-prep utility
and its man page when we're on a platform that has lttng.

The problem is that this is only half-correct. The build system
unconditionally installs the man page for rbd-replay-prep, regardless of
whether lttng was present or absent, and (by extension,) without regard
for whether we've built and installed the rbd-replay-prep binary or not.

We have two options: either the build system should be adjusted to
conditionally skip installing rbd-replay-prep(8), or else we should just
adjust the RPM packaging to always ship the man page. This commit does
the latter.

Backport: firefly
Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
(cherry picked from commit 6a98dacde1d42f5c599feb53b45c3c5ee8515e51)

Conflicts:
ceph.spec.in
        because rbd-replay-many does not exist in giant

ceph.spec.in

index 8a37b03310cde4aba299750de72305e3e464f769..3de96fe8b16840eca0e54c34a3b23148c273ca3f 100644 (file)
@@ -743,9 +743,9 @@ ln -sf %{_libdir}/librbd.so.1 /usr/lib64/qemu/librbd.so.1
 %{_bindir}/ceph-osdomap-tool
 %{_bindir}/ceph-kvstore-tool
 %{_mandir}/man8/rbd-replay.8*
+%{_mandir}/man8/rbd-replay-prep.8*
 %{_bindir}/rbd-replay
 %if (0%{?fedora} >= 20 || 0%{?rhel} == 6)
-%{_mandir}/man8/rbd-replay-prep.8*
 %{_bindir}/rbd-replay-prep
 %endif