mon: pass by ref

CID 717044: Big parameter passed by value (PASS_BY_VALUE)
Passing parameter to of type entity_inst_t (size 152 bytes) by value.

CID 717045: Big parameter passed by value (PASS_BY_VALUE)
Passing parameter a of type entity_addr_t (size 136 bytes) by value.

Signed-off-by: Sage Weil <sage@inktank.com>

diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc
index 62650f0d2f4fa2ddf8d117bcb4193287b1a84a4b..872644cce381164332b886033e1ebdbf89265ed5 100644 (file)
--- a/src/mon/Monitor.cc
+++ b/src/mon/Monitor.cc
@@ -1685,7 +1685,7 @@ void Monitor::handle_forward(MForward *m)
   m->put();
 }
 
-void Monitor::try_send_message(Message *m, entity_inst_t to)
+void Monitor::try_send_message(Message *m, const entity_inst_t& to)
 {
   dout(10) << "try_send_message " << *m << " to " << to << dendl;
 

diff --git a/src/mon/Monitor.h b/src/mon/Monitor.h
index 49605fd4aa94d791e0a2f5e163742837c05dc6ab..7476c2c77c603dba142dd49b6e8a49652351e604 100644 (file)
--- a/src/mon/Monitor.h
+++ b/src/mon/Monitor.h
@@ -368,7 +368,7 @@ public:
   
   void forward_request_leader(PaxosServiceMessage *req);
   void handle_forward(MForward *m);
-  void try_send_message(Message *m, entity_inst_t to);
+  void try_send_message(Message *m, const entity_inst_t& to);
   void send_reply(PaxosServiceMessage *req, Message *reply);
   void no_reply(PaxosServiceMessage *req);
   void resend_routed_requests();

diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc
index 76b6f01957bce35c268c73c8349765827c2b7711..bbc42a0ecc54b8a29383c528f3eb33b1229b66e3 100644 (file)
--- a/src/mon/OSDMonitor.cc
+++ b/src/mon/OSDMonitor.cc
@@ -1328,7 +1328,7 @@ void OSDMonitor::send_incremental(epoch_t first, entity_inst_t& dest, bool oneti
 
 
 
-epoch_t OSDMonitor::blacklist(entity_addr_t a, utime_t until)
+epoch_t OSDMonitor::blacklist(const entity_addr_t& a, utime_t until)
 {
   dout(10) << "blacklist " << a << " until " << until << dendl;
   pending_inc.new_blacklist[a] = until;

diff --git a/src/mon/OSDMonitor.h b/src/mon/OSDMonitor.h
index c58636666b705c3d67171d3e7d2a762faaa16f27..4992e7a8a41c2c323772a19019b30f5207131ab2 100644 (file)
--- a/src/mon/OSDMonitor.h
+++ b/src/mon/OSDMonitor.h
@@ -279,7 +279,7 @@ private:
     send_incremental(m, start);
   }
 
-  epoch_t blacklist(entity_addr_t a, utime_t until);
+  epoch_t blacklist(const entity_addr_t& a, utime_t until);
 
   void dump_info(Formatter *f);