os/bluestore: Collection::split_cache no longer purges cache

There are 2 cases when Collection::split_cache is used:
1) Merge Collections.
   It this case we get more elements in dest collection,
   but we do not want to trim by force as it might cause stall.
2) Split Collection
   Source cache is getting thinner, and dest cache is growing.
   Similarly, trimming dest will cause stall.

Decision:
It is better to not trim forcibly and relay on gradual trimming
from MempoolThread or client IO.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>

diff --git a/src/os/bluestore/BlueStore.cc b/src/os/bluestore/BlueStore.cc
index ca5a9c40783b7c9f6f366b91355b6e1a1f7a9b62..7828dd000b08afc2e62745250d17678c1da27210 100644 (file)
--- a/src/os/bluestore/BlueStore.cc
+++ b/src/os/bluestore/BlueStore.cc
@@ -5522,7 +5522,9 @@ void BlueStore::Collection::split_cache(
       }
     }
   }
-  dest->cache->_trim();
+  // The cache has now more elements.
+  // Trimming right away will cause stalls.
+  // It will get adjusted in MempoolThread
 }
 // =======================================================