]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/telemetry: pass leaderboard flag even w/o ident 41699/head
authorSage Weil <sage@newdream.net>
Fri, 4 Jun 2021 17:49:40 +0000 (12:49 -0500)
committerSage Weil <sage@newdream.net>
Fri, 4 Jun 2021 17:49:40 +0000 (12:49 -0500)
Allow non-identified clusters to appear in the leaderboard.
The leaderboard option still defaults to false, so the change here
is that if they opt in to leaderboard but not ident we'll see
that on the backend.

Note that a leaderboard still does not exist (yet), so this doesn't
have any immediate impact.  But if/when we do create one, it will
allow us to show big clusters (that opt in) on the leaderboard
as 'unidentified' or similar.

Signed-off-by: Sage Weil <sage@newdream.net>
src/pybind/mgr/telemetry/module.py

index bad39bcec520075b1b2516f8c9481ccdf2dbba57..637d8ff7fc95d9a66ebce11f91a579a558732a53 100644 (file)
@@ -401,7 +401,7 @@ class Module(MgrModule):
         if not channels:
             channels = self.get_active_channels()
         report = {
-            'leaderboard': False,
+            'leaderboard': self.leaderboard,
             'report_version': 1,
             'report_timestamp': datetime.utcnow().isoformat(),
             'report_id': self.report_id,
@@ -411,8 +411,6 @@ class Module(MgrModule):
         }
 
         if 'ident' in channels:
-            if self.leaderboard:
-                report['leaderboard'] = True
             for option in ['description', 'contact', 'organization']:
                 report[option] = getattr(self, option)