]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
osd: add comment to explain why EC pool is disallowed
authormyoungwon oh <ohmyoungwon@gmail.com>
Fri, 6 Nov 2020 10:36:39 +0000 (19:36 +0900)
committermyoungwon oh <ohmyoungwon@gmail.com>
Fri, 6 Nov 2020 13:53:06 +0000 (22:53 +0900)
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsumg.com>
src/osd/PrimaryLogPG.cc

index 47db8c5603d0e1a29b4087adc2e456fe5d42a58f..af6a5a8dfe76cced11bdd4aa12bc7dab8c3d4243 100644 (file)
@@ -10125,7 +10125,12 @@ int PrimaryLogPG::do_cdc(const object_info_t& oi, bufferlist& bl, vector<pair<ui
   }
   while (cur_off < oi.size && cur_off < max_window_size) {
     bufferlist chunk_data;
-    // TODO: Do we need to support EC?
+    /**
+     * We disable EC pool as a base tier of distributed dedup.
+     * The reason why we disallow erasure code pool here is that the EC pool does not support objects_read_sync(). 
+     * Therefore, we should change the current implementation totally to make EC pool compatible. 
+     * As s result, we leave this as a future work.
+     */
     int r = pgbackend->objects_read_sync(
        oi.soid, cur_off, max_window_size, 0, &chunk_data);
     if (r < 0) {