]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
test_librbd.cc: fix USE_AFTER_FREE
authorDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Thu, 12 Mar 2015 20:55:33 +0000 (21:55 +0100)
committerDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Thu, 12 Mar 2015 20:55:33 +0000 (21:55 +0100)
Fix for:
CID 1251462 (#1 of 1): Use after free (USE_AFTER_FREE)
1. alias: Assigning: cur_name = names. Now both point to the same storage.
3. freed_arg: free frees names.
6. pass_freed_arg: Passing freed pointer cur_name as an argument to printf.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
src/test/librbd/test_librbd.cc

index cf76c67c7b645c4914014adb1631cc86ba556d72..cb39c6d45944f0f98ae37fc9d39416c15854e978 100644 (file)
@@ -333,7 +333,7 @@ int test_ls(rados_ioctx_t io_ctx, size_t num_expected, ...)
     printf("expected = %s\n", expected);
     std::set<std::string>::iterator it = image_names.find(expected);
     if (it != image_names.end()) {
-      printf("found %s\n", cur_name);
+      printf("found %s\n", expected);
       image_names.erase(it);
     } else {
       ADD_FAILURE() << "Unable to find image " << expected;