ceph_authtool.cc: use empty() instead of size()

Use empty() since it should be prefered as it has, following the
standard, a constant time complexity regardless of the containter
type. The same is not guaranteed for size().

warning from cppchecker was:
[src/ceph_authtool.cc:124]: (performance) Possible inefficient
  checking for 'caps' emptiness.
[src/ceph_authtool.cc:237]: (performance) Possible inefficient
  checking for 'caps' emptiness.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

diff --git a/src/ceph_authtool.cc b/src/ceph_authtool.cc
index d4d205a4fa14c5141bdc3241b3d5a10d6be5a212..3075d9c69a78068a19493633d212ee03ffcfb128 100644 (file)
--- a/src/ceph_authtool.cc
+++ b/src/ceph_authtool.cc
@@ -121,7 +121,7 @@ int main(int argc, const char **argv)
        !add_key.empty() ||
        list ||
        !caps_fn.empty() ||
-       caps.size() ||
+       !caps.empty() ||
        set_auid ||
        print_key ||
        create_keyring ||
@@ -234,7 +234,7 @@ int main(int argc, const char **argv)
     keyring.set_caps(ename, caps);
     modified = true;
   }
-  if (caps.size()) {
+  if (!caps.empty()) {
     keyring.set_caps(ename, caps);
     modified = true;
   }