]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
os/aio: remove the redundant memset(struct iocb) 13662/head
authorJianpeng Ma <jianpeng.ma@intel.com>
Mon, 27 Feb 2017 16:41:26 +0000 (00:41 +0800)
committerJianpeng Ma <jianpeng.ma@intel.com>
Mon, 27 Feb 2017 16:41:26 +0000 (00:41 +0800)
In fact, io_prep_read/write/pwritev/preadv do the memset(struct iocb).
So no need do it.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
src/os/filestore/FileJournal.h
src/os/fs/FS.h

index c804f354d58fa468b6a69174f850fce877bfd1f2..00fc4b484489e88341b598c21eb53168d2cde705 100644 (file)
@@ -257,7 +257,6 @@ private:
     aio_info(bufferlist& b, uint64_t o, uint64_t s)
       : iov(NULL), done(false), off(o), len(b.length()), seq(s) {
       bl.claim(b);
-      memset((void*)&iocb, 0, sizeof(iocb));
     }
     ~aio_info() {
       delete[] iov;
index fdda7dabfc5662152c059e0c32273e84b72937f1..0dc8dcb3764f031df851d656070eaa9785921150 100644 (file)
@@ -65,7 +65,6 @@ public:
     boost::intrusive::list_member_hook<> queue_item;
 
     aio_t(void *p, int f) : priv(p), fd(f), offset(0), length(0), rval(-1000) {
-      memset(&iocb, 0, sizeof(iocb));
     }
 
     void pwritev(uint64_t _offset, uint64_t len) {