]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph-filestore-dump.cc: pass OSDSuperblock by reference
authorDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Mon, 10 Mar 2014 17:14:16 +0000 (18:14 +0100)
committerDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Mon, 10 Mar 2014 17:14:16 +0000 (18:14 +0100)
CID 1100693 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE)
 pass_by_value: Passing parameter superblock of type OSDSuperblock
 (size 240 bytes) by value.

CID 1100694 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE)
 pass_by_value: Passing parameter sb of type OSDSuperblock (size 240 bytes)
 by value.

CID 1100695 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE)
 pass_by_value: Passing parameter sb of type OSDSuperblock (size 240 bytes)
 by value.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
src/tools/ceph-filestore-dump.cc

index 6c8b309a0123afd7cc96bca9b0a41ad5a8e0b9b7..78ac8391fd21be5f4992936deff01aed98896e00 100644 (file)
@@ -167,7 +167,7 @@ struct pg_begin {
   pg_t pgid;
   OSDSuperblock superblock;
 
-  pg_begin(pg_t pg, OSDSuperblock sb):
+  pg_begin(pg_t pg, const OSDSuperblock& sb):
     pgid(pg), superblock(sb) { }
   pg_begin() { }
 
@@ -702,7 +702,7 @@ void write_super()
 }
 
 int do_export(ObjectStore *fs, coll_t coll, pg_t pgid, pg_info_t &info,
-    epoch_t map_epoch, __u8 struct_ver, OSDSuperblock superblock)
+    epoch_t map_epoch, __u8 struct_ver, const OSDSuperblock& superblock)
 {
   PGLog::IndexedLog log;
   pg_missing_t missing;
@@ -949,7 +949,7 @@ int get_pg_metadata(ObjectStore *store, coll_t coll, bufferlist &bl)
   return 0;
 }
 
-int do_import(ObjectStore *store, OSDSuperblock sb)
+int do_import(ObjectStore *store, OSDSuperblock& sb)
 {
   bufferlist ebl;
   pg_info_t info;