]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
qa/tasks/rbd_mirror_thrash: don't use random.randrange() on floats 67144/head
authorIlya Dryomov <idryomov@gmail.com>
Fri, 30 Jan 2026 15:32:35 +0000 (16:32 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Fri, 30 Jan 2026 20:25:16 +0000 (21:25 +0100)
This stopped working in Python 3.12:

  Changed in version 3.12: Automatic conversion of non-integer types
  is no longer supported. Calls such as randrange(10.0) and
  randrange(Fraction(10, 1)) now raise a TypeError.

Fixes: https://tracker.ceph.com/issues/74676
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
qa/tasks/rbd_mirror_thrash.py

index a42d19e7083723b24b9b2778b1caa1051f7d5db5..a5b7ae71f54d0cc25067ab6a2c34015185fc3cfd 100644 (file)
@@ -109,7 +109,7 @@ class RBDMirrorThrasher(Thrasher, Greenlet):
         while not self.stopping.is_set():
             delay = self.max_thrash_delay
             if self.randomize:
-                delay = random.randrange(self.min_thrash_delay, self.max_thrash_delay)
+                delay = random.uniform(self.min_thrash_delay, self.max_thrash_delay)
 
             if delay > 0.0:
                 self.log('waiting for {delay} secs before thrashing'.format(delay=delay))
@@ -145,7 +145,7 @@ class RBDMirrorThrasher(Thrasher, Greenlet):
                 # wait for a while before restarting
                 delay = self.max_revive_delay
                 if self.randomize:
-                    delay = random.randrange(0.0, self.max_revive_delay)
+                    delay = random.uniform(0.0, self.max_revive_delay)
 
                 self.log('waiting for {delay} secs before reviving daemons'.format(delay=delay))
                 sleep(delay)