]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph-backport.sh: correctly add note to backport tracker
authorNathan Cutler <ncutler@suse.com>
Mon, 7 Oct 2019 19:40:12 +0000 (21:40 +0200)
committerNathan Cutler <ncutler@suse.com>
Thu, 10 Oct 2019 12:22:28 +0000 (14:22 +0200)
Before this commit, the JSON was wrong and Redmine silently ignored the note.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
src/script/ceph-backport.sh

index 894e30d5b8aeae466c9e6629d4f92862544891ac..595cbe68d6cbf17707baacc3e5b958ba04f10e9b 100755 (executable)
@@ -174,7 +174,7 @@ function deduce_remote {
 
 function display_version_message_and_exit {
     echo "$this_script: Ceph backporting script, version $SCRIPT_VERSION"
-    exit 0
+    exit 0 
 }
 
 function eol {
@@ -815,7 +815,7 @@ pgrep firefox >/dev/null && firefox ${backport_pr_url}
 
 debug "Updating backport tracker issue ${redmine_url}"
 redmine_status=2 # In Progress
-remote_api_status_code=$(curl --write-out %{http_code} --output /dev/null --silent -X PUT --header 'Content-type: application/json' --data-binary '{"issue":{"description":"https://github.com/ceph/ceph/pull/'$backport_pr_number'","status_id":'$redmine_status',"assigned_to_id":'$redmine_user_id'},"notes":"Updated automatically by ceph-backport.sh version '$SCRIPT_VERSION'"}' ${redmine_url}'.json?key='$redmine_key)
+remote_api_status_code=$(curl --write-out %{http_code} --output /dev/null --silent -X PUT --header 'Content-type: application/json' --data-binary '{"issue":{"description":"https://github.com/ceph/ceph/pull/'$backport_pr_number'","status_id":'$redmine_status',"assigned_to_id":'$redmine_user_id',"notes":"Updated automatically by ceph-backport.sh version '$SCRIPT_VERSION'"}}' ${redmine_url}'.json?key='$redmine_key)
 if [ "${remote_api_status_code:0:1}" = "2" ] ; then
     info "${redmine_url} updated"
 elif [ "${remote_api_status_code:0:1}" = "4" ] ; then