]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph-dedup-tool: warn on hash collision
authorSage Weil <sage@newdream.net>
Tue, 12 May 2020 16:53:14 +0000 (11:53 -0500)
committerSage Weil <sage@newdream.net>
Wed, 27 May 2020 12:47:27 +0000 (07:47 -0500)
Signed-off-by: Sage Weil <sage@newdream.net>
src/tools/ceph_dedup_tool.cc

index d41177ce8c949774d9e313e0aea521da9985b7e6..ddf3efdabd244e938105f3f9274e63813050ea98 100644 (file)
@@ -389,9 +389,11 @@ void EstimateDedupRatio::add_chunk_fp_to_stat(bufferlist &chunk)
 
   auto p = local_chunk_statistics.find(fp);
   if (p != local_chunk_statistics.end()) {
-    uint64_t count = p->second.first;
-    count++;
-    local_chunk_statistics[fp] = make_pair(count, chunk.length());
+    p->second.first++;
+    if (p->second.second != chunk.length()) {
+      cerr << "warning: hash collision on " << fp << ": was " << p->second.second
+          << " now " << chunk.length() << std::endl;
+    }
   } else {
     local_chunk_statistics[fp] = make_pair(1, chunk.length());
   }