]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/rbd_support: remove CreateSnapshotRequests __del__() 54290/head
authorRamana Raja <rraja@redhat.com>
Mon, 30 Oct 2023 15:05:27 +0000 (11:05 -0400)
committerRamana Raja <rraja@redhat.com>
Wed, 1 Nov 2023 12:47:51 +0000 (08:47 -0400)
There is no need for CreateSnapshotRequests.__del__() that calls
CreateSnapshotRequests.wait_for_pending().
MirrorSnapshotScheduleHandler.shutdown() already calls
CreateSnapshotRequests.wait_for_pending().

Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit fed1e87685a698876cf167b3681327e5b0066ee6)

src/pybind/mgr/rbd_support/mirror_snapshot_schedule.py

index 58cb3ce9e1fc855e6c8f666df649bb758aef981f..2f98f294c5ffba573ea66d53e1afed644b2f0127 100644 (file)
@@ -42,9 +42,6 @@ class CreateSnapshotRequests:
         self.queue: List[ImageSpec] = []
         self.ioctxs: Dict[Tuple[str, str], Tuple[rados.Ioctx, Set[ImageSpec]]] = {}
 
-    def __del__(self) -> None:
-        self.wait_for_pending()
-
     def wait_for_pending(self) -> None:
         with self.lock:
             while self.pending: