]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
decrement WBThrottle perfcounters in clear_object 2076/head
authorDan van der Ster <daniel.vanderster@cern.ch>
Mon, 7 Jul 2014 13:51:51 +0000 (15:51 +0200)
committerDan van der Ster <daniel.vanderster@cern.ch>
Mon, 7 Jul 2014 14:02:05 +0000 (16:02 +0200)
We observed that the WBThrottle perfcounters are leaking upwards
at a rate of around 50-100 ios_dirtied per day. The counters are
currently not decremented in clear_object, so that's the likely
explanation. Decrement them like elsewhere in WBThrottle.

Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
src/os/WBThrottle.cc

index 0354ceb8ccefcff15efe692b1e2428255be48adc..7d0bcf6f45f2169cc34855e98522940fc4e6983b 100644 (file)
@@ -242,7 +242,10 @@ void WBThrottle::clear_object(const ghobject_t &hoid)
     return;
 
   cur_ios -= i->second.first.ios;
+  logger->dec(l_wbthrottle_ios_dirtied, i->second.first.ios);
   cur_size -= i->second.first.size;
+  logger->dec(l_wbthrottle_bytes_dirtied, i->second.first.size);
+  logger->dec(l_wbthrottle_inodes_dirtied);
 
   pending_wbs.erase(i);
   remove_object(hoid);