common: use ref to avoid unnecessary memory copy

Fixes: http://tracker.ceph.com/issues/19107
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>

diff --git a/src/common/ConfUtils.cc b/src/common/ConfUtils.cc
index d24990f97192d3f6abd54198bc59d5d801c54393..2c403d950c8f51c4826c3ee6d69cc3256e98b1c1 100644 (file)
--- a/src/common/ConfUtils.cc
+++ b/src/common/ConfUtils.cc
@@ -40,8 +40,8 @@ using std::string;
 
 ////////////////////////////// ConfLine //////////////////////////////
 ConfLine::
-ConfLine(const std::string &key_, const std::string val_,
-      const std::string newsection_, const std::string comment_, int line_no_)
+ConfLine(const std::string &key_, const std::string &val_,
+      const std::string &newsection_, const std::string &comment_, int line_no_)
   : key(key_), val(val_), newsection(newsection_)
 {
   // If you want to implement writable ConfFile support, you'll need to save

diff --git a/src/common/ConfUtils.h b/src/common/ConfUtils.h
index 7a5b79a047a1ce3094eba11992046d01022c6992..19ec188a7112262ee502273616632291885f0d7b 100644 (file)
--- a/src/common/ConfUtils.h
+++ b/src/common/ConfUtils.h
@@ -39,8 +39,8 @@
  */
 class ConfLine {
 public:
-  ConfLine(const std::string &key_, const std::string val_,
-          const std::string newsection_, const std::string comment_, int line_no_);
+  ConfLine(const std::string &key_, const std::string &val_,
+          const std::string &newsection_, const std::string &comment_, int line_no_);
   bool operator<(const ConfLine &rhs) const;
   friend std::ostream &operator<<(std::ostream& oss, const ConfLine &l);