rgw: role/svc cosmetic comments & ws cleanup

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

diff --git a/src/rgw/rgw_role.h b/src/rgw/rgw_role.h
index fed1bfc67f57604de455430a8778a514dd3abe25..ffb48e2bf182ea139da43d4ed6cdbc8c1a2fab14 100644 (file)
--- a/src/rgw/rgw_role.h
+++ b/src/rgw/rgw_role.h
@@ -216,6 +216,12 @@ public:
        bool from_remote_zone) override;
 };
 
+/// Defines control classes that call the low level service layer that handles
+/// storage, svc classes implement the low level object operations. Ctl classes
+/// can span over multiple service classes, for eg. User Ctl classes need to
+/// update the user indices when buckets are added/removed RoleCtl classes may
+/// need to update the RGW Account class that a role has been added deleted
+/// under an account.
 class RGWRoleCtl {
   struct Svc {
     RGWSI_Role *role {nullptr};

diff --git a/src/rgw/services/svc_role.h b/src/rgw/services/svc_role.h
index 4cd68ce188414debc002ff80ad0d3a3df38c6631..037b22c0632e63f7530f1970885a793095bc05f9 100644 (file)
--- a/src/rgw/services/svc_role.h
+++ b/src/rgw/services/svc_role.h
@@ -70,7 +70,7 @@ class RGWSI_Role: public RGWServiceInstance
 
   virtual int read_info(RGWSI_MetaBackend::Context *ctx,
                        const std::string& role_id,
-                       rgw::sal::RGWRole *role,
+                       rgw::sal::RGWRole *role,  // out param
                        RGWObjVersionTracker * const objv_tracker,
                        real_time * const pmtime,
                        std::map<std::string, bufferlist> * pattrs,
@@ -122,10 +122,10 @@ class RGWSI_Role: public RGWServiceInstance
                          const DoutPrefixProvider *dpp) = 0;
 
   virtual int list_roles_by_path_prefix(RGWSI_MetaBackend::Context *ctx,
-                                const std::string& path,
-                                const std::string& tenant,
-                                std::vector<rgw::sal::RGWRole>& roles,
-                                optional_yield y,
+                                                               const std::string& path,
+                                                               const std::string& tenant,
+                                                               std::vector<rgw::sal::RGWRole>& roles,  // out param
+                                                               optional_yield y,
                                                                const DoutPrefixProvider *dpp) = 0;
 
 };