]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/seastore: segment_manager: fix -Wunused warnings 69122/head
authorKefu Chai <k.chai@proxmox.com>
Wed, 27 May 2026 08:52:31 +0000 (16:52 +0800)
committerKefu Chai <k.chai@proxmox.com>
Wed, 27 May 2026 09:42:22 +0000 (17:42 +0800)
7f739adae2 dropped the last log call from get_segment_manager(), after
which `LOG_PREFIX(SegmentManager::get_segment_manager)` and
`SET_SUBSYS(seastore_device)` had no remaining users under `HAVE_ZNS`,
generating:

```
src/crimson/os/seastore/segment_manager.cc:38:3: warning: unused variable 'FNAME' [-Wunused-variable]
   38 |   LOG_PREFIX(SegmentManager::get_segment_manager);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/crimson/common/log.h:49:38: note: expanded from macro 'LOG_PREFIX'
   49 | #define LOG_PREFIX(x) constexpr auto FNAME = #x
      |                                      ^~~~~
src/crimson/os/seastore/segment_manager.cc:10:1: warning: unused variable 'SOURCE_SUBSYS' [-Wunused-const-variable]
   10 | SET_SUBSYS(seastore_device);
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
src/crimson/common/log.h:46:52: note: expanded from macro 'SET_SUBSYS'
   46 | #define SET_SUBSYS(subname_) static constexpr auto SOURCE_SUBSYS = ceph_subsys_##subname_
      |                                                    ^~~~~~~~~~~~~
2 warnings generated.
```

drop both to silence them.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
src/crimson/os/seastore/segment_manager.cc

index 501137a5835a8fae5d9a53c008bea646743255f3..c99de668e1ff2d672c3c58bfb3a0f82762149e42 100644 (file)
@@ -7,7 +7,6 @@
 
 #ifdef HAVE_ZNS
 #include "crimson/os/seastore/segment_manager/zbd.h"
-SET_SUBSYS(seastore_device);
 #endif
 
 
@@ -35,7 +34,6 @@ SegmentManager::get_segment_manager(
 {
   const std::string device_block = device + "/block";
 #ifdef HAVE_ZNS
-  LOG_PREFIX(SegmentManager::get_segment_manager);
   if (dtype == device_type_t::ZBD) {
     co_return std::make_unique<segment_manager::zbd::ZBDSegmentManager>(
         device_block);