]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
cephx: don't leak Authorizers on each request
authorGreg Farnum <gregory.farnum@dreamhost.com>
Thu, 6 Oct 2011 16:58:48 +0000 (09:58 -0700)
committerGreg Farnum <gregory.farnum@dreamhost.com>
Thu, 6 Oct 2011 16:58:48 +0000 (09:58 -0700)
It's not clear to me why this is a class member -- it's only
written to or read from in this function, which allocates a fresh
one each time it's called.

Signed-off-by: Greg Farnum <gregory.farnum@dreamhost.com>
src/auth/cephx/CephxClientHandler.cc

index 5ec090a415bae7c3c0666d97ed72023010f5a762..64722e587008bb988779ec75f4ff6354e3801be9 100644 (file)
@@ -81,6 +81,7 @@ int CephxClientHandler::build_request(bufferlist& bl)
     if (!authorizer)
       return -EINVAL;
     bl.claim_append(authorizer->bl);
+    delete authorizer;
 
     CephXServiceTicketRequest req;
     req.keys = need;