]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
test/test_rgw_admin*: don't compare unsigend to less than 0
authorDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Thu, 26 Apr 2018 08:08:24 +0000 (10:08 +0200)
committerDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Thu, 26 Apr 2018 10:17:54 +0000 (12:17 +0200)
Make checks simpler, use empty() instead of 'length() <= 0'.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
src/test/test_rgw_admin_meta.cc
src/test/test_rgw_admin_opstate.cc

index 9695a3c6d0c92a20d33e695421d22e79320cbcf9..c0ade77ab48f6467a286a16698ac14f93e0d630b 100644 (file)
@@ -132,8 +132,7 @@ int test_helper::extract_input(int argc, char *argv[]){
       ERR_CHECK_NEXT_PARAM(rgw_admin_path);
     }else return -1;
   }
-  if(host.length() <= 0 ||
-     rgw_admin_path.length() <= 0)
+  if(host.empty() || rgw_admin_path.empty())
     return -1;
   return 0;
 }
index 464bd85a86ab2670a093ead68e3163191f86227a..b999bb68982df00f0f640b217be95a15ffef82a5 100644 (file)
@@ -135,8 +135,7 @@ int test_helper::extract_input(int argc, char *argv[]){
       ERR_CHECK_NEXT_PARAM(rgw_admin_path);
     }else return -1;
   }
-  if(host.length() <= 0 ||
-     rgw_admin_path.length() <= 0)
+  if(host.empty() || rgw_admin_path.empty())
     return -1;
   return 0;
 }