]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw: silence compilation #warnings
authorYehuda Sadeh <yehuda@redhat.com>
Thu, 18 Feb 2016 23:20:20 +0000 (15:20 -0800)
committerYehuda Sadeh <yehuda@redhat.com>
Thu, 18 Feb 2016 23:20:20 +0000 (15:20 -0800)
these are now FIXMEs

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
src/rgw/rgw_admin.cc
src/rgw/rgw_data_sync.cc
src/rgw/rgw_sync.cc

index cb4730b1a7770b336e3504dac1b946aefb0d7218..fb4c2a927b91cff9dbfedffa37f501202ea7f844 100644 (file)
@@ -2772,8 +2772,6 @@ int main(int argc, char **argv)
          return -ret;
        }
 
-        #warning need to implement for backward compatabilty
-
        if (reset_regions) {
           zonegroupmap.zonegroups.clear();
         }
index 2243426d873c01c93f6b6469d3a4e6ffa107b9b7..5d8c72f21e54d68be6a564aec55d5539e5764efd 100644 (file)
@@ -484,7 +484,7 @@ public:
                                                   oid_prefix);
       yield {
         string entrypoint = string("/admin/metadata/bucket.instance");
-#warning need a better scaling solution here, requires streaming output
+        /* FIXME: need a better scaling solution here, requires streaming output */
         call(new RGWReadRESTResourceCR<list<string> >(store->ctx(), sync_env->conn, sync_env->http_manager,
                                                       entrypoint, NULL, &result));
       }
@@ -694,7 +694,7 @@ public:
         yield call(sync_env->error_logger->log_error_cr(sync_env->conn->get_remote_id(), "data", bucket_name + ":" + bucket_instance,
                                                         -sync_status, string("failed to sync bucket instance: ") + cpp_strerror(-sync_status)));
       }
-#warning what do do in case of error
+      /* FIXME: what do do in case of error */
       if (!entry_marker.empty()) {
         /* update marker */
         yield call(marker_tracker->finish(entry_marker));
index f17e1e3ab00153762534f9d92a1262b23ba65c16..fbf3e56889b956cf5bab8ae46caa21ea9c7208a5 100644 (file)
@@ -659,7 +659,7 @@ public:
       for (; sections_iter != sections.end(); ++sections_iter) {
         yield {
          string entrypoint = string("/admin/metadata/") + *sections_iter;
-#warning need a better scaling solution here, requires streaming output
+          /* FIXME: need a better scaling solution here, requires streaming output */
          call(new RGWReadRESTResourceCR<list<string> >(cct, conn, sync_env->http_manager,
                                       entrypoint, NULL, &result));
        }
@@ -963,7 +963,7 @@ int RGWMetaSyncSingleEntryCR::operate() {
       sync_status = retcode;
 
       if (sync_status == -ENOENT) {
-#warning remove entry from local
+        /* FIXME: do we need to remove the entry from the local zone? */
         break;
       }