]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
Merge pull request #24681 from tspmelo/wip-npm-update
authorLenz Grimmer <lenz@grimmer.com>
Wed, 7 Nov 2018 10:55:14 +0000 (11:55 +0100)
committerGitHub <noreply@github.com>
Wed, 7 Nov 2018 10:55:14 +0000 (11:55 +0100)
mgr/dashboard: Update npm packages

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
1  2 
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-list/osd-list.component.spec.ts

index 497a8b27ee7248e8ab72c4b55345fd3a6b9b90aa,dd8ec94d14e22b5b2274a57533e8af7036ff50c5..02a17796dd684a3e93cbce101c68245cf9f58bb7
@@@ -125,25 -125,33 +125,23 @@@ describe('OsdListComponent', () => 
    });
  
    describe('test table actions in submenu', () => {
-     beforeEach(
-       fakeAsync(() => {
-         // The menu needs a click to render the dropdown!
-         const dropDownToggle = fixture.debugElement.query(By.css('.dropdown-toggle'));
-         dropDownToggle.triggerEventHandler('click', null);
-         tick();
-         fixture.detectChanges();
-       })
-     );
+     beforeEach(fakeAsync(() => {
+       // The menu needs a click to render the dropdown!
+       const dropDownToggle = fixture.debugElement.query(By.css('.dropdown-toggle'));
+       dropDownToggle.triggerEventHandler('click', null);
+       tick();
+       fixture.detectChanges();
+     }));
  
 -    /**
 -     * Helper function to retrieve menu item
 -     * @param selector
 -     */
 -    const getMenuItem = (selector: string): DebugElement => {
 -      return fixture.debugElement
 -        .query(By.directive(TableActionsComponent))
 -        .query(By.css(selector));
 -    };
 +    it('has all menu entries disabled', () => {
 +      const tableActionElement = fixture.debugElement.query(By.directive(TableActionsComponent));
 +      const toClassName = TestBed.get(TableActionsComponent).toClassName;
 +      const getActionClasses = (action: CdTableAction) =>
 +        tableActionElement.query(By.css('.' + toClassName(action.name))).classes;
  
 -    it('has menu entries disabled for entries without create permission', () => {
 -      component.tableActions
 -        .filter((tableAction) => tableAction.permission !== 'create')
 -        .map((tableAction) => tableAction.name)
 -        .map(TestBed.get(TableActionsComponent).toClassName)
 -        .map((className) => getMenuItem(`.${className}`))
 -        .forEach((debugElement) => {
 -          expect(debugElement.classes.disabled).toBe(true);
 -        });
 +      component.tableActions.forEach((action) => {
 +        expect(getActionClasses(action).disabled).toBe(true);
 +      });
      });
    });