]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mon: Fix ranged-construct warning
authorAdam C. Emerson <aemerson@redhat.com>
Mon, 7 Mar 2022 23:46:04 +0000 (18:46 -0500)
committerKefu Chai <tchaikov@gmail.com>
Tue, 22 Mar 2022 15:26:54 +0000 (23:26 +0800)
In the case of an uint32_t there's no benefit to a reference so just
remove the const and make the copy.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
src/mon/OSDMonitor.cc

index be1de29012b149d6df6462f53421b2c48c6582c2..db9383e86076d3e748ed1ee4ca9552f7c1258e82 100644 (file)
@@ -899,13 +899,13 @@ void OSDMonitor::update_from_paxos(bool *need_bootstrap)
       t = MonitorDBStore::TransactionRef();
       tx_size = 0;
     }
-    for (const auto [osd, state] : inc.new_state) {
+    for (auto [osd, state] : inc.new_state) {
       if (state & CEPH_OSD_UP) {
        // could be marked up *or* down, but we're too lazy to check which
        last_osd_report.erase(osd);
       }
     }
-    for (const auto [osd, weight] : inc.new_weight) {
+    for (auto [osd, weight] : inc.new_weight) {
       if (weight == CEPH_OSD_OUT) {
         // manually marked out, so drop it
         osd_epochs.erase(osd);