osd: report -EINVAL to on_finish in asok_route_to_pg catch

The handler passed the stale locate result (0) while returning -EINVAL,
so callers saw success on a bad_cmd_get failure.

Only reachable via the "scrubdebug" asok command (the sole user of
asok_route_to_pg) when a parameter fails type parsing.

Signed-off-by: Sun Yuechi <sunyuechi@iscas.ac.cn>

diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc
index 6ee2ec0b8acb5d1e839667fe1d348ff3f64ea174..e6e7489a6753db68b156337f458f807be10ea4f7 100644 (file)
--- a/src/osd/OSD.cc
+++ b/src/osd/OSD.cc
@@ -2760,7 +2760,7 @@ int OSD::asok_route_to_pg(
   } catch (const TOPNSPC::common::bad_cmd_get& e) {
     (*target_pg)->unlock();
     ss << e.what();
-    on_finish(ret, ss.str(), outbl);
+    on_finish(-EINVAL, ss.str(), outbl);
     return -EINVAL;
   }
 }