]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
Revert "osd: When scrub finds an attr error mark shard inconsistent"
authorDavid Zafman <dzafman@redhat.com>
Wed, 31 May 2017 20:49:18 +0000 (13:49 -0700)
committerDavid Zafman <dzafman@redhat.com>
Wed, 31 May 2017 23:05:10 +0000 (16:05 -0700)
This reverts commit 44736aac74493b5532c9e3574a37a3642766f212.

Signed-off-by: David Zafman <dzafman@redhat.com>
src/osd/PGBackend.cc

index 57e4c001ef64fe8aca3f1a1f9818d79565df3834..fab9ee826642c676747668e9f08f706a8fd38d65 100644 (file)
@@ -782,15 +782,16 @@ void PGBackend::be_compare_scrubmaps(
                                   object_error,
                                   ss);
        // Some errors might have already been set in be_select_auth_object()
-       if (found || shard_map[j->first].errors != 0) {
+       if (shard_map[j->first].errors != 0) {
          cur_inconsistent.insert(j->first);
           if (shard_map[j->first].has_deep_errors())
            ++deep_errors;
-         else if (shard_map[j->first].has_shallow_errors())
+         else
            ++shallow_errors;
          // Only true if be_compare_scrub_objects() found errors and put something
          // in ss.
-         errorstream << pgid << " shard " << j->first << ": soid " << *k
+         if (found)
+           errorstream << pgid << " shard " << j->first << ": soid " << *k
                      << " " << ss.str() << "\n";
        } else {
          // XXX: The auth shard might get here that we don't know