]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
Add error check for object_map->sync() 7281/head
authorChendi Xue <chendi.xue@intel.com>
Tue, 19 Jan 2016 07:35:46 +0000 (15:35 +0800)
committerChendi Xue <chendi.xue@intel.com>
Tue, 19 Jan 2016 07:35:46 +0000 (15:35 +0800)
There lacks error check after doing object_map->sync under
sync_entry, which is OK when omap deployed in the same device
with object data, but it is better to add error check in case
object_map->sync failed.

Signed-off-by: Chendi Xue <chendi.xue@intel.com>
src/os/filestore/FileStore.cc

index 5cb73e7b01a3291b40ed321a7c0137c966bc192b..7aa64ebffe5c527fe07fe987cfd309045bce1193 100644 (file)
@@ -3692,8 +3692,13 @@ void FileStore::sync_entry()
        apply_manager.commit_started();
        op_tp.unpause();
 
-       object_map->sync();
-       int err = backend->syncfs();
+       int err = object_map->sync();
+       if (err < 0) {
+         derr << "object_map sync got " << cpp_strerror(err) << dendl;
+         assert(0 == "object_map sync returned error");
+       }
+
+       err = backend->syncfs();
        if (err < 0) {
          derr << "syncfs got " << cpp_strerror(err) << dendl;
          assert(0 == "syncfs returned error");