]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw/services: don't expose RGWServices::notify 65775/head
authorCasey Bodley <cbodley@redhat.com>
Tue, 7 Oct 2025 16:09:11 +0000 (12:09 -0400)
committerCasey Bodley <cbodley@redhat.com>
Thu, 9 Oct 2025 15:00:47 +0000 (11:00 -0400)
RGWSI_Notify is only used internally by RGWSI_SysObj_Cache where the
dependency is injected to RGWSI_SysObj_Cache::init(). there's no need to
expose a pointer to RGWSI_Notify to the rest of the application,
especially now that it can be a nullptr

Signed-off-by: Casey Bodley <cbodley@redhat.com>
src/rgw/driver/rados/rgw_service.cc
src/rgw/driver/rados/rgw_service.h

index ec6d4aea052dd8edc2aa0ff444b132f92e7173c0..b69ac11462c3e46c8722c9872188bbc5df41f613 100644 (file)
@@ -282,7 +282,6 @@ int RGWServices::do_init(CephContext *_cct, rgw::sal::RadosStore* driver, bool h
   config_key = config_key_rados;
   datalog_rados = _svc.datalog_rados.get();
   mdlog = _svc.mdlog.get();
-  notify = _svc.notify.get();
   zone = _svc.zone.get();
   zone_utils = _svc.zone_utils.get();
   quota = _svc.quota.get();
index 96fe99c367fd02f932a21ffce55b00bf817c677c..cdc2392da186362159646713fea32b1393df54e8 100644 (file)
@@ -132,7 +132,6 @@ struct RGWServices
   RGWSI_ConfigKey *config_key{nullptr};
   RGWDataChangesLog *datalog_rados{nullptr};
   RGWSI_MDLog *mdlog{nullptr};
-  RGWSI_Notify *notify{nullptr};
   RGWSI_Zone *zone{nullptr};
   RGWSI_ZoneUtils *zone_utils{nullptr};
   RGWSI_Quota *quota{nullptr};