]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
build/ops: unify command substitution in install-deps.sh
authorNathan Cutler <ncutler@suse.com>
Wed, 1 Aug 2018 10:33:58 +0000 (12:33 +0200)
committerNathan Cutler <ncutler@suse.com>
Wed, 1 Aug 2018 10:36:31 +0000 (12:36 +0200)
The $() form is preferable to `` because folks (like me) might be using
` as a keyboard shortcut to GNU Screen, causing havoc to ensue whenever
copy-pasting the ` character.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
install-deps.sh

index b6ad79a07182d1810d0f1397c25049b0841b462a..bc7e2681ac0932d6ff564648402c7bbf9fce68cc 100755 (executable)
@@ -21,7 +21,7 @@ if test $(id -u) != 0 ; then
 fi
 export LC_ALL=C # the following is vulnerable to i18n
 
-ARCH=`uname -m`
+ARCH=$(uname -m)
 
 function install_seastar_deps {
     if [ $WITH_SEASTAR ]; then
@@ -135,7 +135,7 @@ EOF
     fi
 }
 
-if [ x`uname`x = xFreeBSDx ]; then
+if [ x$(uname)x = xFreeBSDx ]; then
     $SUDO pkg install -yq \
         devel/babeltrace \
         devel/git \