]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
objecter: clarify a few lock assertions
authorJosh Durgin <jdurgin@redhat.com>
Tue, 10 Feb 2015 23:49:57 +0000 (15:49 -0800)
committerJosh Durgin <jdurgin@redhat.com>
Wed, 11 Feb 2015 00:36:39 +0000 (16:36 -0800)
These are always called with the rwlock locked for write.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
src/osdc/Objecter.cc

index edc1a1b50bd8f8b51808936e6b699fcbb8c0c63b..68714c63a3c47a4939b97eb2bd82694469f1ff69 100644 (file)
@@ -1771,7 +1771,7 @@ void Objecter::kick_requests(OSDSession *session)
 
 void Objecter::_kick_requests(OSDSession *session, map<uint64_t, LingerOp *>& lresend)
 {
-  assert(rwlock.is_locked());
+  assert(rwlock.is_wlocked());
 
   // resend ops
   map<ceph_tid_t,Op*> resend;  // resend in tid order
@@ -1815,7 +1815,7 @@ void Objecter::_kick_requests(OSDSession *session, map<uint64_t, LingerOp *>& lr
 
 void Objecter::_linger_ops_resend(map<uint64_t, LingerOp *>& lresend)
 {
-  assert(rwlock.is_locked());
+  assert(rwlock.is_wlocked());
 
   while (!lresend.empty()) {
     LingerOp *op = lresend.begin()->second;
@@ -2578,7 +2578,7 @@ void Objecter::_session_linger_op_assign(OSDSession *to, LingerOp *op)
 void Objecter::_session_linger_op_remove(OSDSession *from, LingerOp *op)
 {
   assert(from == op->session);
-  assert(from->lock.is_locked());
+  assert(from->lock.is_wlocked());
 
   if (from->is_homeless()) {
     num_homeless_ops.dec();