FlatIndex: terminate dir_name buffer passed to strncpy

CID 716836: Buffer not null terminated (BUFFER_SIZE_WARNING)At (1): Calling
strncpy with a maximum size argument of 4096 bytes on destination array
"dir_name" of size 4096 bytes might leave the destination string unterminated.

Signed-off-by: Samuel Just <sam.just@inktank.com>

diff --git a/src/os/FlatIndex.cc b/src/os/FlatIndex.cc
index 7a1bfba43adf7fff2ec5f6a067b045752b7d8a61..b3d79f541951bceb867622d686346238f17baa68 100644 (file)
--- a/src/os/FlatIndex.cc
+++ b/src/os/FlatIndex.cc
@@ -390,6 +390,7 @@ int FlatIndex::collection_list_partial(const hobject_t &start,
 int FlatIndex::collection_list(vector<hobject_t> *ls) {
   char dir_name[PATH_MAX], buf[PATH_MAX], new_name[PATH_MAX];
   strncpy(dir_name, base_path.c_str(), sizeof(dir_name));
+  dir_name[sizeof(dir_name)-1]='\0';
 
   DIR *dir = ::opendir(dir_name);
   if (!dir)