import { PaginateObservable } from '~/app/shared/api/paginate.model';
import { CdFormGroup } from '~/app/shared/forms/cd-form-group';
import { SharedModule } from '~/app/shared/shared.module';
-import { configureTestBed, FormHelper } from '~/testing/unit-test-helper';
+import { configureTestBed, FormHelper, Mocks } from '~/testing/unit-test-helper';
import { ServiceFormComponent } from './service-form.component';
+import { PoolService } from '~/app/shared/api/pool.service';
+
+// for 'nvmeof' service
+const mockPools = [
+ Mocks.getPool('pool-1', 1, ['cephfs']),
+ Mocks.getPool('rbd', 2),
+ Mocks.getPool('pool-2', 3)
+];
+class MockPoolService {
+ getList() {
+ return of(mockPools);
+ }
+}
describe('ServiceFormComponent', () => {
let component: ServiceFormComponent;
configureTestBed({
declarations: [ServiceFormComponent],
- providers: [NgbActiveModal],
+ providers: [NgbActiveModal, { provide: PoolService, useClass: MockPoolService }],
imports: [
HttpClientTestingModule,
NgbTypeaheadModule,
describe('should test service nvmeof', () => {
beforeEach(() => {
+ component.serviceType = 'nvmeof';
formHelper.setValue('service_type', 'nvmeof');
- formHelper.setValue('service_id', 'svc');
- formHelper.setValue('pool', 'xyz');
- formHelper.setValue('group', 'abc');
+ component.ngOnInit();
+ fixture.detectChanges();
});
- it('should submit nvmeof', () => {
- component.onSubmit();
- expect(cephServiceService.create).toHaveBeenCalledWith({
- service_type: 'nvmeof',
- service_id: 'svc',
- placement: {},
- unmanaged: false,
- pool: 'xyz',
- group: 'abc'
- });
+ it('should set rbd pools correctly onInit', () => {
+ expect(component.pools.length).toBe(3);
+ expect(component.rbdPools.length).toBe(2);
+ });
+
+ it('should set default values correctly onInit', () => {
+ expect(form.get('service_type').value).toBe('nvmeof');
+ expect(form.get('group').value).toBe('default');
+ expect(form.get('pool').value).toBe('rbd');
+ expect(form.get('service_id').value).toBe('rbd.default');
+ });
+
+ it('should reflect correct values on group change', () => {
+ // Initially the group value should be 'default'
+ expect(component.serviceForm.get('group')?.value).toBe('default');
+ const groupInput = fixture.debugElement.query(By.css('#group')).nativeElement;
+ // Simulate input value change
+ groupInput.value = 'foo';
+ // Trigger the input event
+ groupInput.dispatchEvent(new Event('input'));
+ // Trigger the change event
+ groupInput.dispatchEvent(new Event('change'));
+ fixture.detectChanges();
+ // Verify values after change
+ expect(form.get('group').value).toBe('foo');
+ expect(form.get('service_id').value).toBe('rbd.foo');
+ });
+
+ it('should reflect correct values on pool change', () => {
+ // Initially the pool value should be 'rbd'
+ expect(component.serviceForm.get('pool')?.value).toBe('rbd');
+ const poolInput = fixture.debugElement.query(By.css('#pool')).nativeElement;
+ // Simulate input value change
+ poolInput.value = 'pool-2';
+ // Trigger the input event
+ poolInput.dispatchEvent(new Event('input'));
+ // Trigger the change event
+ poolInput.dispatchEvent(new Event('change'));
+ fixture.detectChanges();
+ // Verify values after change
+ expect(form.get('pool').value).toBe('pool-2');
+ expect(form.get('service_id').value).toBe('pool-2.default');
});
it('should throw error when there is no service id', () => {
it('should throw error when there is no group', () => {
formHelper.expectErrorChange('group', '', 'required');
});
+
+ it('should hide the count element when service_type is "nvmeof"', () => {
+ const countEl = fixture.debugElement.query(By.css('#count'));
+ expect(countEl).toBeNull();
+ });
+
+ it('should submit nvmeof', () => {
+ component.onSubmit();
+ expect(cephServiceService.create).toHaveBeenCalledWith({
+ service_type: 'nvmeof',
+ service_id: 'rbd.default',
+ placement: {},
+ unmanaged: false,
+ pool: 'rbd',
+ group: 'default'
+ });
+ });
});
describe('should test service smb', () => {
const poolId = fixture.debugElement.query(By.css('#pool')).nativeElement;
expect(poolId.disabled).toBeTruthy();
});
+
+ it('should not edit groups for nvmeof service', () => {
+ component.serviceType = 'nvmeof';
+ formHelper.setValue('service_type', 'nvmeof');
+ component.ngOnInit();
+ fixture.detectChanges();
+ const groupId = fixture.debugElement.query(By.css('#group')).nativeElement;
+ expect(groupId.disabled).toBeTruthy();
+ });
});
});
});
]
],
group: [
- null,
+ 'default',
CdValidators.requiredIf({
service_type: 'nvmeof'
})
this.serviceForm.get('count').setValue(2);
break;
case 'iscsi':
- case 'nvmeof':
case 'cephfs-mirror':
case 'nfs':
case 'grafana':
);
}
- setNvmeofServiceId(): void {
- const defaultRbdPool: string = this.rbdPools?.find((p: Pool) => p.pool_name === 'rbd')
- ?.pool_name;
- if (defaultRbdPool) {
- this.serviceForm.get('pool').setValue(defaultRbdPool);
- }
+ onNvmeofGroupChange(groupName: string) {
+ const pool = this.serviceForm.get('pool').value;
+ if (pool) this.serviceForm.get('service_id').setValue(`${pool}.${groupName}`);
+ else this.serviceForm.get('service_id').setValue(groupName);
}
- onNvmeofGroupChange(groupName: string) {
- this.serviceForm.get('service_id').setValue(groupName);
+ getDefaultBlockPool(): string {
+ // returns 'rbd' pool otherwise the first block pool
+ return (
+ this.rbdPools?.find((p: Pool) => p.pool_name === 'rbd')?.pool_name ||
+ this.rbdPools?.[0].pool_name
+ );
+ }
+
+ setNvmeofServiceIdAndPool(): void {
+ const defaultBlockPool: string = this.getDefaultBlockPool();
+ const group: string = this.serviceForm.get('group').value;
+ if (defaultBlockPool && group) {
+ this.serviceForm.get('pool').setValue(defaultBlockPool);
+ this.serviceForm.get('service_id').setValue(`${defaultBlockPool}.${group}`);
+ } else {
+ this.serviceForm.get('service_id').setValue(null);
+ }
}
requiresServiceId(serviceType: string) {
setServiceId(serviceId: string): void {
const requiresServiceId: boolean = this.requiresServiceId(serviceId);
if (requiresServiceId && serviceId === 'nvmeof') {
- this.setNvmeofServiceId();
+ this.setNvmeofServiceIdAndPool();
} else if (requiresServiceId) {
this.serviceForm.get('service_id').setValue(null);
} else {
onBlockPoolChange() {
const selectedBlockPool = this.serviceForm.get('pool').value;
- if (selectedBlockPool) {
+ const group = this.serviceForm.get('group').value;
+ if (selectedBlockPool && group) {
+ this.serviceForm.get('service_id').setValue(`${selectedBlockPool}.${group}`);
+ } else if (selectedBlockPool) {
this.serviceForm.get('service_id').setValue(selectedBlockPool);
} else {
this.serviceForm.get('service_id').setValue(null);
projects / ceph.git / commitdiff