]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
PG: remove unused PG::_cond
authorLoic Dachary <loic@dachary.org>
Thu, 15 Aug 2013 17:42:13 +0000 (19:42 +0200)
committerLoic Dachary <loic@dachary.org>
Thu, 22 Aug 2013 00:10:58 +0000 (02:10 +0200)
http://tracker.ceph.com/issues/5510 refs #5510

Signed-off-by: Loic Dachary <loic@dachary.org>
src/osd/OSD.cc
src/osd/PG.cc
src/osd/PG.h
src/osd/ReplicatedPG.cc

index 55f11707189b13ff286dad09d077c447db59711f..9a58289eda4558b4218954ede18b6864dd70e4b3 100644 (file)
@@ -1522,7 +1522,6 @@ int OSD::shutdown()
     dout(20) << " kicking pg " << p->first << dendl;
     p->second->lock();
     p->second->on_shutdown();
-    p->second->kick();
     p->second->unlock();
     p->second->osr->flush();
   }
index 49ea61a603ac9556c73fc3ebcf99b80a22d3044f..cd5621cddf26584eedead9c0fde87bcf7e8a1d52 100644 (file)
@@ -4527,9 +4527,6 @@ void PG::start_peering_interval(const OSDMapRef lastmap,
 {
   const OSDMapRef osdmap = get_osdmap();
 
-  // -- there was a change! --
-  kick();
-
   set_last_peering_reset();
 
   vector<int> oldacting, oldup;
index 14ac7c9fac52105a386417fb4a7f8913a23c9d94..720ce67bca33a4c3691de8f6dde439280b5845ec 100644 (file)
@@ -232,7 +232,6 @@ protected:
    * put_unlock() when done with the current pointer (_most common_).
    */  
   Mutex _lock;
-  Cond _cond;
   atomic_t ref;
 
 #ifdef PG_DEBUG_REFS
@@ -261,14 +260,6 @@ public:
   bool is_locked() const {
     return _lock.is_locked();
   }
-  void wait() {
-    assert(_lock.is_locked());
-    _cond.Wait(_lock);
-  }
-  void kick() {
-    assert(_lock.is_locked());
-    _cond.Signal();
-  }
 
 #ifdef PG_DEBUG_REFS
   uint64_t get_with_id();
index 6c7ec56af88989b4ba5ad5f589e33563cc2ee95d..29fc5f8d6cba07e0ed0e1f4b74651a7ebec763d3 100644 (file)
@@ -4739,9 +4739,6 @@ void ReplicatedPG::put_object_context(ObjectContext *obc)
     if (obc->registered)
       object_contexts.erase(obc->obs.oi.soid);
     delete obc;
-
-    if (object_contexts.empty())
-      kick();
   }
 }