mon/PGMap: add more constness

Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/src/mon/PGMap.cc b/src/mon/PGMap.cc
index cebbe1e3a6123564b92361df031fad8fcb3a0333..dc3a4fe6087a960f0539c82c260c1514d91bc5c1 100644 (file)
--- a/src/mon/PGMap.cc
+++ b/src/mon/PGMap.cc
@@ -1473,7 +1473,7 @@ void PGMap::generate_test_instances(list<PGMap*>& o)
   }
 }
 
-void PGMap::get_filtered_pg_stats(string& state, int64_t poolid, int64_t osdid,
+void PGMap::get_filtered_pg_stats(const string& state, int64_t poolid, int64_t osdid,
                                   bool primary, set<pg_t>& pgs)
 {
   int type = 0;

diff --git a/src/mon/PGMap.h b/src/mon/PGMap.h
index b34b815cad3ab3068b2be613900867a11e752192..a2676432d2360518a9b812f96f4a04bfa89fba3a 100644 (file)
--- a/src/mon/PGMap.h
+++ b/src/mon/PGMap.h
@@ -294,7 +294,7 @@ public:
   void dump_osd_blocked_by_stats(Formatter *f) const;
   void print_osd_blocked_by_stats(std::ostream *ss) const;
 
-  void get_filtered_pg_stats(string& state, int64_t poolid, int64_t osdid,
+  void get_filtered_pg_stats(const string& state, int64_t poolid, int64_t osdid,
                              bool primary, set<pg_t>& pgs);
   void recovery_summary(Formatter *f, list<string> *psl,
                         const pool_stat_t& delta_sum) const;

diff --git a/src/osd/osd_types.cc b/src/osd/osd_types.cc
index 7679dc4b19451a00b5c740d2a602c6b9eedeeb44..3703ae6a60978d36428722ebb1d44e968ffdb199 100644 (file)
--- a/src/osd/osd_types.cc
+++ b/src/osd/osd_types.cc
@@ -770,7 +770,7 @@ std::string pg_state_string(int state)
   return ret;
 }
 
-int pg_string_state(std::string state)
+int pg_string_state(const std::string& state)
 {
   int type;
   if (state == "active")

diff --git a/src/osd/osd_types.h b/src/osd/osd_types.h
index 18f5402501966d1233676b4c25258001a4ded4ee..d6d147a49c05d6aa67a468d3822ce0d399f59824 100644 (file)
--- a/src/osd/osd_types.h
+++ b/src/osd/osd_types.h
@@ -773,7 +773,7 @@ inline ostream& operator<<(ostream& out, const osd_stat_t& s) {
 
 std::string pg_state_string(int state);
 std::string pg_vector_string(const vector<int32_t> &a);
-int pg_string_state(std::string state);
+int pg_string_state(const std::string& state);
 
 
 /*